summaryrefslogtreecommitdiff
authorbinqi zhang <binqi.zhang@amlogic.com>2020-03-20 04:31:17 (GMT)
committer sky zhou <sky.zhou@amlogic.com>2020-05-21 12:13:28 (GMT)
commita9c21ba0def56de36fa46a73a97bba45b1f85673 (patch)
tree86863caefc7b7422c6ff26a65cec0d7565d42e6e
parent2ad946a29b4dad712adda4b691c685b4ed33c618 (diff)
downloadhwcomposer-a9c21ba0def56de36fa46a73a97bba45b1f85673.zip
hwcomposer-a9c21ba0def56de36fa46a73a97bba45b1f85673.tar.gz
hwcomposer-a9c21ba0def56de36fa46a73a97bba45b1f85673.tar.bz2
display: fix wrong logic in fraction mode code [1/1]
PD#SWPL-22731 Problem: 1.mFracMode is bool type, but mFracMode has three modes; 2.mFracRefreshRates will always empty becasue bNonFractionMode is initialized to false and no place to change the value before if (bNonFractionMode == false); Solution: 1.mFracMode should be int type; 2.when mFracMode equals 0 or 1, hwc should push the fracMode.refreshRate to mFracRefreshRates; Verify: Verify on newton. Change-Id: I312f25d7db9b7245a9003bd2a8595fa7c82f6ab1 Signed-off-by: binqi zhang <binqi.zhang@amlogic.com>
Diffstat
-rw-r--r--common/display/ConnectorHdmi.cpp3
-rw-r--r--common/display/ConnectorHdmi.h2
2 files changed, 2 insertions, 3 deletions
diff --git a/common/display/ConnectorHdmi.cpp b/common/display/ConnectorHdmi.cpp
index 583e5a9..192504e 100644
--- a/common/display/ConnectorHdmi.cpp
+++ b/common/display/ConnectorHdmi.cpp
@@ -156,8 +156,7 @@ int32_t ConnectorHdmi::addDisplayMode(std::string& mode) {
fracMode.refreshRate = (modeInfo.refreshRate * 1000) / (float)1001;
mDisplayModes.emplace(mDisplayModes.size(), fracMode);
MESON_LOGI("add fraction display mode (%s)", fracMode.name);
- if (bNonFractionMode == true)
- mFracRefreshRates.push_back(fracMode.refreshRate);
+ mFracRefreshRates.push_back(fracMode.refreshRate);
}
} else {
/*for non fraction display mode, we also add it in MODE_FRACTION*/
diff --git a/common/display/ConnectorHdmi.h b/common/display/ConnectorHdmi.h
index 14e8bd9..261af15 100644
--- a/common/display/ConnectorHdmi.h
+++ b/common/display/ConnectorHdmi.h
@@ -61,7 +61,7 @@ private:
std::vector<uint8_t> mEDID;
bool mIsEDIDValid;
- bool mFracMode;
+ int32_t mFracMode;
std::vector<float> mFracRefreshRates;
drm_hdr_capabilities mHdrCapabilities;
};