summaryrefslogtreecommitdiff
authorNick Desaulniers <ndesaulniers@google.com>2019-02-11 19:30:04 (GMT)
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-17 06:36:38 (GMT)
commit1347aa2a4d9a5ebd6b4fb7720c43e5e5be68c198 (patch)
tree65c7c94fcf0aeca50987c7385fbc64703c95d048
parent4d8b1fd22eacd0ba4ae9a9c547094690b4487b65 (diff)
downloadcommon-1347aa2a4d9a5ebd6b4fb7720c43e5e5be68c198.zip
common-1347aa2a4d9a5ebd6b4fb7720c43e5e5be68c198.tar.gz
common-1347aa2a4d9a5ebd6b4fb7720c43e5e5be68c198.tar.bz2
kbuild: clang: choose GCC_TOOLCHAIN_DIR not on LD
commit ad15006cc78459d059af56729c4d9bed7c7fd860 upstream. This causes an issue when trying to build with `make LD=ld.lld` if ld.lld and the rest of your cross tools aren't in the same directory (ex. /usr/local/bin) (as is the case for Android's build system), as the GCC_TOOLCHAIN_DIR then gets set based on `which $(LD)` which will point where LLVM tools are, not GCC/binutils tools are located. Instead, select the GCC_TOOLCHAIN_DIR based on another tool provided by binutils for which LLVM does not provide a substitute for, such as elfedit. Fixes: 785f11aa595b ("kbuild: Add better clang cross build support") Link: https://github.com/ClangBuiltLinux/linux/issues/341 Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Tested-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat
-rw-r--r--Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index f44094d..ba3c4880 100644
--- a/Makefile
+++ b/Makefile
@@ -507,7 +507,7 @@ endif
ifeq ($(cc-name),clang)
ifneq ($(CROSS_COMPILE),)
CLANG_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%))
-GCC_TOOLCHAIN_DIR := $(dir $(shell which $(LD)))
+GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit))
CLANG_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)
GCC_TOOLCHAIN := $(realpath $(GCC_TOOLCHAIN_DIR)/..)
endif