summaryrefslogtreecommitdiff
authorShakeel Butt <shakeelb@google.com>2017-10-06 01:07:24 (GMT)
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org>2017-12-25 13:23:43 (GMT)
commit206e1621ba721bf4bb4b71938a867ba5b8305bcb (patch)
tree9be20e487e2fd6acb07f2dd8c1bfe5e41a8978e8
parentbdb33bb5e2cea11bb94907e6ca9666c067fc9fd3 (diff)
downloadcommon-206e1621ba721bf4bb4b71938a867ba5b8305bcb.zip
common-206e1621ba721bf4bb4b71938a867ba5b8305bcb.tar.gz
common-206e1621ba721bf4bb4b71938a867ba5b8305bcb.tar.bz2
kvm, mm: account kvm related kmem slabs to kmemcg
[ Upstream commit 46bea48ac241fe0b413805952dda74dd0c09ba8b ] The kvm slabs can consume a significant amount of system memory and indeed in our production environment we have observed that a lot of machines are spending significant amount of memory that can not be left as system memory overhead. Also the allocations from these slabs can be triggered directly by user space applications which has access to kvm and thus a buggy application can leak such memory. So, these caches should be accounted to kmemcg. Signed-off-by: Shakeel Butt <shakeelb@google.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat
-rw-r--r--arch/x86/kvm/mmu.c4
-rw-r--r--virt/kvm/kvm_main.c2
2 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index d29c745..0a324e1 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -5052,13 +5052,13 @@ int kvm_mmu_module_init(void)
{
pte_list_desc_cache = kmem_cache_create("pte_list_desc",
sizeof(struct pte_list_desc),
- 0, 0, NULL);
+ 0, SLAB_ACCOUNT, NULL);
if (!pte_list_desc_cache)
goto nomem;
mmu_page_header_cache = kmem_cache_create("kvm_mmu_page_header",
sizeof(struct kvm_mmu_page),
- 0, 0, NULL);
+ 0, SLAB_ACCOUNT, NULL);
if (!mmu_page_header_cache)
goto nomem;
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 68c078e..1b20768 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3904,7 +3904,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align,
if (!vcpu_align)
vcpu_align = __alignof__(struct kvm_vcpu);
kvm_vcpu_cache = kmem_cache_create("kvm_vcpu", vcpu_size, vcpu_align,
- 0, NULL);
+ SLAB_ACCOUNT, NULL);
if (!kvm_vcpu_cache) {
r = -ENOMEM;
goto out_free_3;