summaryrefslogtreecommitdiff
authorArnd Bergmann <arnd@arndb.de>2017-08-02 20:31:58 (GMT)
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-08 05:19:07 (GMT)
commit30ca85a54edd0a22890e7004e5fe613b34d9d2b2 (patch)
treebc4f729c40cc32c1071d1345aeaab144694f3c6c
parent51a27f037fb328d55389252ae67bcc2b9d70e7ac (diff)
downloadcommon-30ca85a54edd0a22890e7004e5fe613b34d9d2b2.zip
common-30ca85a54edd0a22890e7004e5fe613b34d9d2b2.tar.gz
common-30ca85a54edd0a22890e7004e5fe613b34d9d2b2.tar.bz2
kasan: avoid -Wmaybe-uninitialized warning
commit e7701557bfdd81ff44cab13a80439319a735d8e2 upstream. gcc-7 produces this warning: mm/kasan/report.c: In function 'kasan_report': mm/kasan/report.c:351:3: error: 'info.first_bad_addr' may be used uninitialized in this function [-Werror=maybe-uninitialized] print_shadow_for_address(info->first_bad_addr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/kasan/report.c:360:27: note: 'info.first_bad_addr' was declared here The code seems fine as we only print info.first_bad_addr when there is a shadow, and we always initialize it in that case, but this is relatively hard for gcc to figure out after the latest rework. Adding an intialization to the most likely value together with the other struct members shuts up that warning. Fixes: b235b9808664 ("kasan: unify report headers") Link: https://patchwork.kernel.org/patch/9641417/ Link: http://lkml.kernel.org/r/20170725152739.4176967-1-arnd@arndb.de Signed-off-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Alexander Potapenko <glider@google.com> Suggested-by: Andrey Ryabinin <aryabinin@virtuozzo.com> Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Dmitry Vyukov <dvyukov@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat
-rw-r--r--mm/kasan/report.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 8ca412a..c505ac5 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -302,6 +302,7 @@ void kasan_report(unsigned long addr, size_t size,
disable_trace_on_warning();
info.access_addr = (void *)addr;
+ info.first_bad_addr = (void *)addr;
info.access_size = size;
info.is_write = is_write;
info.ip = ip;