| author | Eric Dumazet <edumazet@google.com> | 2019-05-16 15:09:57 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-25 16:26:43 (GMT) |
| commit | 350d6591c9670767e1002919dc866c83dddfc806 (patch) | |
| tree | d2d6857fc9cadbe82541915f35265f5b1e2eb1ab | |
| parent | a5f56b52c878585b12b8bc37f737dcce4a660c64 (diff) | |
| download | common-350d6591c9670767e1002919dc866c83dddfc806.zip common-350d6591c9670767e1002919dc866c83dddfc806.tar.gz common-350d6591c9670767e1002919dc866c83dddfc806.tar.bz2 | |
net: avoid weird emergency message
[ Upstream commit d7c04b05c9ca14c55309eb139430283a45c4c25f ]
When host is under high stress, it is very possible thread
running netdev_wait_allrefs() returns from msleep(250)
10 seconds late.
This leads to these messages in the syslog :
[...] unregister_netdevice: waiting for syz_tun to become free. Usage count = 0
If the device refcount is zero, the wait is over.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 8e187f9..5a319644 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7499,7 +7499,7 @@ static void netdev_wait_allrefs(struct net_device *dev) refcnt = netdev_refcnt_read(dev); - if (time_after(jiffies, warning_time + 10 * HZ)) { + if (refcnt && time_after(jiffies, warning_time + 10 * HZ)) { pr_emerg("unregister_netdevice: waiting for %s to become free. Usage count = %d\n", dev->name, refcnt); warning_time = jiffies; |