| author | Chengguang Xu <cgxu519@gmx.com> | 2019-04-23 05:08:35 (GMT) |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2019-05-09 04:47:05 (GMT) |
| commit | 8c22521c5d1d7d8db3cfc7d34a8bfd08f841184f (patch) | |
| tree | aeda9ac8510b4e22c9458e24859a49c419a42671 | |
| parent | 8feb65b938764c65b8d20c348b80ed059fbf3ab2 (diff) | |
| download | common-8c22521c5d1d7d8db3cfc7d34a8bfd08f841184f.zip common-8c22521c5d1d7d8db3cfc7d34a8bfd08f841184f.tar.gz common-8c22521c5d1d7d8db3cfc7d34a8bfd08f841184f.tar.bz2 | |
f2fs: remove redundant check in f2fs_file_write_iter()
We have already checked flag IOCB_DIRECT in the sanity
check of flag IOCB_NOWAIT, so don't have to check it
again here.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
| -rw-r--r-- | fs/f2fs/file.c | 22 |
1 files changed, 9 insertions, 13 deletions
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index bfaaa1a..f89df31 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2835,20 +2835,16 @@ static ssize_t f2fs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) if (iov_iter_fault_in_readable(from, iov_iter_count(from))) set_inode_flag(inode, FI_NO_PREALLOC); - if ((iocb->ki_flags & IOCB_NOWAIT) && - (iocb->ki_flags & IOCB_DIRECT)) { - if (!f2fs_overwrite_io(inode, iocb->ki_pos, + if ((iocb->ki_flags & IOCB_NOWAIT)) { + if (!f2fs_overwrite_io(inode, iocb->ki_pos, iov_iter_count(from)) || - f2fs_has_inline_data(inode) || - f2fs_force_buffered_io(inode, - iocb, from)) { - clear_inode_flag(inode, - FI_NO_PREALLOC); - inode_unlock(inode); - ret = -EAGAIN; - goto out; - } - + f2fs_has_inline_data(inode) || + f2fs_force_buffered_io(inode, iocb, from)) { + clear_inode_flag(inode, FI_NO_PREALLOC); + inode_unlock(inode); + ret = -EAGAIN; + goto out; + } } else { preallocated = true; target_size = iocb->ki_pos + iov_iter_count(from); |