| author | Ondrej Mosnacek <omosnace@redhat.com> | 2018-09-13 08:51:31 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-13 19:16:57 (GMT) |
| commit | b957cd4d7de6892a35a66c1cf7b5199aafe1b2c9 (patch) | |
| tree | b10f6249621a91bf88f5cd4db1b2dff1d3adc25d | |
| parent | d699af340bfdea2a3fa94210dcfe743fa09f2cdd (diff) | |
| download | common-b957cd4d7de6892a35a66c1cf7b5199aafe1b2c9.zip common-b957cd4d7de6892a35a66c1cf7b5199aafe1b2c9.tar.gz common-b957cd4d7de6892a35a66c1cf7b5199aafe1b2c9.tar.bz2 | |
crypto: lrw - Fix out-of bounds access on counter overflow
commit fbe1a850b3b1522e9fc22319ccbbcd2ab05328d2 upstream.
When the LRW block counter overflows, the current implementation returns
128 as the index to the precomputed multiplication table, which has 128
entries. This patch fixes it to return the correct value (127).
Fixes: 64470f1b8510 ("[CRYPTO] lrw: Liskov Rivest Wagner, a tweakable narrow block cipher mode")
Cc: <stable@vger.kernel.org> # 2.6.20+
Reported-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | crypto/lrw.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/crypto/lrw.c b/crypto/lrw.c index 6f9908a..d38a382 100644 --- a/crypto/lrw.c +++ b/crypto/lrw.c @@ -132,7 +132,12 @@ static inline int get_index128(be128 *block) return x + ffz(val); } - return x; + /* + * If we get here, then x == 128 and we are incrementing the counter + * from all ones to all zeros. This means we must return index 127, i.e. + * the one corresponding to key2*{ 1,...,1 }. + */ + return 127; } static int crypt(struct blkcipher_desc *d, |