summaryrefslogtreecommitdiff
authorBen Hutchings <ben@decadent.org.uk>2019-05-07 19:04:04 (GMT)
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-10 15:52:11 (GMT)
commitc9257238740ee492574cf686313037be7470e7ec (patch)
tree5f25d34d1f59d6ef80f2755bf50105b223fe542f
parentbab022db454a4c074054f30344416f12821ca11f (diff)
downloadcommon-c9257238740ee492574cf686313037be7470e7ec.zip
common-c9257238740ee492574cf686313037be7470e7ec.tar.gz
common-c9257238740ee492574cf686313037be7470e7ec.tar.bz2
timer/debug: Change /proc/timer_stats from 0644 to 0600
The timer_stats facility should filter and translate PIDs if opened from a non-initial PID namespace, to avoid leaking information about the wider system. It should also not show kernel virtual addresses. Unfortunately it has now been removed upstream (as redundant) instead of being fixed. For stable, fix the leak by restricting access to root only. A similar change was already made for the /proc/timer_list file. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat
-rw-r--r--kernel/time/timer_stats.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c
index 087204c..c74920f 100644
--- a/kernel/time/timer_stats.c
+++ b/kernel/time/timer_stats.c
@@ -417,7 +417,7 @@ static int __init init_tstats_procfs(void)
{
struct proc_dir_entry *pe;
- pe = proc_create("timer_stats", 0644, NULL, &tstats_fops);
+ pe = proc_create("timer_stats", 0600, NULL, &tstats_fops);
if (!pe)
return -ENOMEM;
return 0;