summaryrefslogtreecommitdiff
authorGuenter Roeck <linux@roeck-us.net>2018-07-01 20:57:16 (GMT)
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org>2018-12-08 12:05:05 (GMT)
commitcd39e296c4d65a4598c882d17373ca5ec99d7416 (patch)
tree8ca7ea1747bbb7a4b7a3cc868e64e0f3aa64e559
parentd041ed258e58e48aff222ad562bb44fdcfcc1482 (diff)
downloadcommon-cd39e296c4d65a4598c882d17373ca5ec99d7416.zip
common-cd39e296c4d65a4598c882d17373ca5ec99d7416.tar.gz
common-cd39e296c4d65a4598c882d17373ca5ec99d7416.tar.bz2
kobject: Replace strncpy with memcpy
commit 77d2a24b6107bd9b3bf2403a65c1428a9da83dd0 upstream. gcc 8.1.0 complains: lib/kobject.c:128:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] lib/kobject.c: In function 'kobject_get_path': lib/kobject.c:125:13: note: length computed here Using strncpy() is indeed less than perfect since the length of data to be copied has already been determined with strlen(). Replace strncpy() with memcpy() to address the warning and optimize the code a little. Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat
-rw-r--r--lib/kobject.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kobject.c b/lib/kobject.c
index b733a83..f58c7f2 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -127,7 +127,7 @@ static void fill_kobj_path(struct kobject *kobj, char *path, int length)
int cur = strlen(kobject_name(parent));
/* back up enough to print this name with '/' */
length -= cur;
- strncpy(path + length, kobject_name(parent), cur);
+ memcpy(path + length, kobject_name(parent), cur);
*(path + --length) = '/';
}