summaryrefslogtreecommitdiff
authorJean Delvare <jdelvare@suse.de>2012-10-02 14:42:36 (GMT)
committer Mike Frysinger <vapier@gentoo.org>2016-04-04 03:59:15 (GMT)
commit8c3f943410ccfd79bb24eaa816dc8d57200d7a4c (patch)
treea120301d91a9c797e62edc76803a11259995dfb5
parent74f58ed48cd6b8bdb3fb265b649db7dea4574341 (diff)
downloadbusybox-8c3f943410ccfd79bb24eaa816dc8d57200d7a4c.zip
busybox-8c3f943410ccfd79bb24eaa816dc8d57200d7a4c.tar.gz
busybox-8c3f943410ccfd79bb24eaa816dc8d57200d7a4c.tar.bz2
kbuild: Fix gcc -x syntax
The correct syntax for gcc -x is "gcc -x assembler", not "gcc -xassembler". Even though the latter happens to work, the former is what is documented in the manual page and thus what gcc wrappers such as icecream do expect. This isn't a cosmetic change. The missing space prevents icecream from recognizing compilation tasks it can't handle, leading to silent kernel miscompilations. Besides me, credits go to Michael Matz and Dirk Mueller for investigating the miscompilation issue and tracking it down to this incorrect -x parameter syntax. Signed-off-by: Jean Delvare <jdelvare@suse.de> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: stable@vger.kernel.org Cc: Bernhard Walle <bernhard@bwalle.de> Cc: Michal Marek <mmarek@suse.cz> Cc: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Michal Marek <mmarek@suse.cz> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat
-rw-r--r--scripts/kconfig/lxdialog/check-lxdialog.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index e3b12c0..c8e8a71 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -38,7 +38,7 @@ trap "rm -f $tmp" 0 1 2 3 15
# Check if we can link to ncurses
check() {
- $cc -xc - -o $tmp 2>/dev/null <<'EOF'
+ $cc -x c - -o $tmp 2>/dev/null <<'EOF'
#include CURSES_LOC
main() {}
EOF