SubtitleManager: needn't to retry getting subtitle service if it's disabled[1/1]

PD#153852

needn't to retry getting subtitle service if it's disabled

Change-Id: Ib44cc45a5409c581361ae871aee853bdffc1bd5f

1 files changed, 8 insertions, 12 deletions

diff --git a/core/java/com/droidlogic/app/SubtitleManager.java b/core/java/com/droidlogic/app/SubtitleManager.java
index a0fb591..2200225 100644
--- a/core/java/com/droidlogic/app/SubtitleManager.java
+++ b/core/java/com/droidlogic/app/SubtitleManager.java
@@ -57,8 +57,12 @@ public class SubtitleManager {
 
         private boolean disable() {
             boolean ret = false;
-            if (SystemProperties.getBoolean ("sys.subtitle.disable", false) ) {
-                ret = true;
+            try {
+                ret = (boolean)Class.forName("android.os.SystemProperties")
+                    .getMethod("getBoolean", new Class[] { String.class, Boolean.TYPE })
+                    .invoke(null, new Object[] { "sys.subtitle.disable", true });
+            } catch (Exception e) {
+                Log.e(TAG,"[start]Exception e:" + e);
             }
             return ret;
         }
@@ -200,16 +204,8 @@ public class SubtitleManager {
         public void start() {
             LOGI("[start]mPath:" + mPath);
 
-            try {
-                boolean isDisabled = (boolean)Class.forName("android.os.SystemProperties")
-                    .getMethod("getBoolean", new Class[] { String.class, Boolean.TYPE })
-                    .invoke(null, new Object[] { "sys.subtitle.disable", true });
-
-                if (isDisabled) {
-                    return;
-                }
-            } catch (Exception e) {
-                Log.e(TAG,"[start]Exception e:" + e);
+            if (disable()) {
+                return;
             }
 
             mThreadStop = false;